Hey folks, any chance we can get this PR merged <g...
# ory-network
b
Hey folks, any chance we can get this PR merged github.com/ory/kratos/pull/4529? This change adds
external_id
support to OAuth flows. I was a bit surprised to find today that this wasn't already working. Looks like @bitter-gigabyte-85859 has done a bunch of work to get this ready. Anything else that's needed to merge it?
@bland-eye-99092 looks like maybe you were reviewing this PR?
It looks like I can't use a token hook to work around this either since the
sub
claim can't be customised by the webhook response ory.com/docs/hydra/guides/claims-at-refresh#…
b
Hi, thanks for checking in and bringing this back on our radar. here's our response (from the PR):
Unfortunately, there are some things in Hydra that use the subject to look up the associated identity in Kratos which will break if this change is merged as-is.
We still want to enable this, though, and have some ideas, but it will take us some time to find the right solution here. I'll keep you updated here once we finalize that process.
b
Thanks @bland-eye-99092 , do you know of a workaround in the meantime? I think our project to rollout OAuth is effectively blocked if the subject doesn't resolve to a known identifier.
Quick update on this one. We're considering adding a token hook to add a custom claim for the external ID.
🙏 1