Hi team! I found a bug in the identity schema docs...
# contributors
a
Hi team! I found a bug in the identity schema docs: the Verification address section on Customize identity schemas uses the
recovery
extension key in both code tabs where it should be
verification
. Anyone copying the snippet silently gets recovery behavior instead of verification. I have a two-line fix ready on my fork and the CLA signed, but I'm blocked from opening the PR by the collaborators only restriction: github.com/ory/docs/compare/…/verification-address-schema-key Could you grant me access to open the PR or feel free to cherry-pick the branch directly if that's simpler? Thanks!
m
Thanks for the report @average-hamburger-62489! Since we now have a monorepo, your PR will be closed and copied over to the internal repo - you'll still get credit etc, but the actual merging will take part in the internal repo. I'll transfer the PR and take care of the rest, thanks a lot!
a
Thanks for transferring the fix! Since I'd like to keep contributing, one question about the monorepo setup: is there still a path for external code contributions (Kratos, Oathkeeper…), or is development internal-only?
m
See here: github.com/ory/kratos/blob/…/CONTRIBUTING.md#… most importantly > All code contributions require prior discussion and agreement with maintainers before opening a pull request. Since the cost of creating new code is basically 0 now, most of the work is now before and after code, so planning and review. So we will only spend time reviewing if the feature/fix/whatever actually makes sense. Before having done the work of writing some code already proved that one thought deeply about what they are contributing - this is not the case anymore. Otherwise contribution workflow remains the same.
a
Very clear, thank you for the explanation !
👍 1